Add a custom meta tag dimension for spelling suggestions #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'd like to track spelling suggestions on page view. Previously, we set the value via javascript, but it was too late as the pageview object payload was already sent. Adding this custom meta tag to the allowed map, will enable us to track if suggestion are displayed on page view.
kr8n3r
force-pushed
the
add-custom-dimension81
branch
from
311d2ad to
173d0b9
Compare
kr8n3r
changed the title
kr8n3r
changed the title
kr8n3r
changed the title
kr8n3r
added a commit
to alphagov/finder-frontend
that referenced
this pull request
Nov 4, 2019
For finders where we show spelling suggestions, we want to track their page view impressions. First part of the work is in static alphagov/static#1927 Here we insert the meta tag into the document head for analtyics script to pick up.
kr8n3r
added a commit
to alphagov/finder-frontend
that referenced
this pull request
Nov 4, 2019
For finders where we show spelling suggestions, we want to track their page view impressions. First part of the work is in static alphagov/static#1927 Here we insert the meta tag into the document head for analytics script to pick up.
barrucadu
approved these changes
Nov 4, 2019
Tetrino
approved these changes
Nov 4, 2019
kr8n3r
added a commit
to alphagov/finder-frontend
that referenced
this pull request
Nov 4, 2019
For finders where we show spelling suggestions, we want to track their page view impressions. First part of the work is in static alphagov/static#1927 Here we insert the meta tag into the document head for analytics script to pick up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add custom meta tag to the dimensionsMap
We'd like to track spelling suggestions on page view. Previously, we set the value via javascript, but it was too late as the pageview object payload was already sent.
Adding this custom meta tag to the allowed map, will enable us
to track if suggestion are displayed on page view.
Trello ticket